Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix:fixed url encode #802

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Fix:fixed url encode #802

merged 1 commit into from
Oct 26, 2020

Conversation

fangyincheng
Copy link
Contributor

What this PR does:

fix that “,” code twice become “%252”.

@codecov-io
Copy link

Codecov Report

Merging #802 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #802      +/-   ##
===========================================
- Coverage    59.80%   59.76%   -0.04%     
===========================================
  Files          259      259              
  Lines        12752    12752              
===========================================
- Hits          7626     7621       -5     
  Misses        4171     4171              
- Partials       955      960       +5
Impacted Files Coverage Δ
config_center/nacos/facade.go 79.31% <0.00%> (-10.35%) ⬇️
metadata/report/delegate/delegate_report.go 29.66% <0.00%> (-9.33%) ⬇️
remoting/kubernetes/watch.go 75.00% <0.00%> (-4.35%) ⬇️
remoting/kubernetes/client.go 72.72% <0.00%> (-3.04%) ⬇️
config_center/nacos/client.go 65.26% <0.00%> (-2.11%) ⬇️
remoting/kubernetes/registry_controller.go 50.20% <0.00%> (-1.23%) ⬇️
remoting/kubernetes/listener.go 50.52% <0.00%> (ø)
filter/filter_impl/hystrix_filter.go 70.19% <0.00%> (+2.88%) ⬆️
registry/consul/service_discovery.go 73.64% <0.00%> (+6.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a3656...5a089ff. Read the comment docs.

@watermelo watermelo self-requested a review October 25, 2020 13:25
@AlexStocks
Copy link
Contributor

Pls do not merge until @fangyincheng adds an ut.

@zouyx zouyx changed the title fixed url encode Fixfixed url encode Oct 26, 2020
@zouyx zouyx changed the title Fixfixed url encode Fix:fixed url encode Oct 26, 2020
@zouyx
Copy link
Member

zouyx commented Oct 26, 2020

Pls do not merge until @fangyincheng adds an ut.

Agree

@AlexStocks AlexStocks merged commit bec8195 into apache:develop Oct 26, 2020
@fangyincheng fangyincheng deleted the fix-path branch October 29, 2020 17:39
@zouyx zouyx added this to the v1.5.5 milestone Oct 30, 2020
AlexStocks added a commit that referenced this pull request Apr 14, 2021
@AlexStocks
Merge pull request #802 from fangyincheng/fix-path
fd3d824 
Fix:fixed url encode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watermelo watermelo watermelo approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

@zouyx zouyx zouyx approved these changes

@hxmhlt hxmhlt Awaiting requested review from hxmhlt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.5-rc1
Development

Successfully merging this pull request may close these issues.
5 participants
@fangyincheng @codecov-io @AlexStocks @zouyx @watermelo